lkml.org 
[lkml]   [2001]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.10pre11 vm rewrite fixes for mainline inclusion and testing
On Wed, Sep 19, 2001 at 10:58:15PM -0700, Andrew Morton wrote:
>
> With this patch against -pre12 the BUG()s in shrink_cache()
> go away.
>
> --- linux-2.4.10-pre12/mm/vmscan.c Wed Sep 19 20:47:21 2001
> +++ linux-akpm/mm/vmscan.c Wed Sep 19 22:49:48 2001
> @@ -435,15 +435,20 @@ static int shrink_cache(struct list_head
>
> if (try_to_free_buffers(page, gfp_mask)) {
> if (!page->mapping) {
> - UnlockPage(page);
> -
> /*
> * Account we successfully freed a page
> * of buffer cache.
> */
> atomic_dec(&buffermem_pages);
>
> + /*
> + * We must not allow an anon page
> + * with no buffers to be visible on
> + * the LRU, so we unlock the page after
> + * taking the lru lock
> + */
> spin_lock(&pagemap_lru_lock);
> + UnlockPage(page);
> __lru_cache_del(page);
>
> /* effectively free the page here */

correct, thanks! Please Linus apply.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.055 / U:2.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site