lkml.org 
[lkml]   [2001]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: Deadlock on the mm->mmap_sem
    Date
    From
    > if we go generic then I strongly recommend my version of the generic
    > semaphores is _much_ faster (and cleaner) than this one

    Not so:-) Your patch, Andrea, grabs the spinlock far more than is necessary.

    > (it even allows more than 2^31 concurrent readers on 64 bit archs ;).

    Easy enough to fix. Just apply this as well:

    --- linux-rwsem-old/include/linux/rwsem.h Wed Sep 19 19:23:44 2001
    +++ linux-rwsem/include/linux/rwsem.h Wed Sep 19 19:23:47 2001
    @@ -26,7 +26,7 @@
    * - if wait_list is not empty, then there are processes waiting for the semaphore
    */
    struct rw_semaphore {
    - int activity;
    + long activity;
    spinlock_t lock;
    struct list_head wait_list;
    };
    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:4.855 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site