lkml.org 
[lkml]   [2001]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.4.10-pre12
On Tue, 18 Sep 2001, Linus Torvalds wrote:
> pre12:
> - Alan Cox: much more merging

Anybody with an idea where this comes from?!?

- There should be a test for a failed kmalloc()
- sun3fb_init_fb() returns void (it returns int in the m68k tree)

diff -u --recursive --new-file v2.4.9/linux/drivers/video/sun3fb.c linux/drivers/video/sun3fb.c
--- v2.4.9/linux/drivers/video/sun3fb.c Thu Apr 26 22:17:27 2001
+++ linux/drivers/video/sun3fb.c Mon Sep 17 22:52:35 2001
@@ -586,9 +586,11 @@
fb->cursor.hwsize.fbx = 32;
fb->cursor.hwsize.fby = 32;

- if (depth > 1 && !fb->color_map)
+ if (depth > 1 && !fb->color_map) {
fb->color_map = kmalloc(256 * 3, GFP_ATOMIC);
-
+ return -ENOMEM;
+ }
+
switch(fbtype) {
#ifdef CONFIG_FB_CGSIX
case FBTYPE_SUNFAST_COLOR:
Gr{oetje,eeting}s,
Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.044 / U:0.156 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site