Messages in this thread |  | | Subject | Re: Linux 2.4.10-pre12 | Date | Wed, 19 Sep 2001 20:51:01 +0100 (BST) | From | Alan Cox <> |
| |
> - There should be a test for a failed kmalloc() > - sun3fb_init_fb() returns void (it returns int in the m68k tree) > > diff -u --recursive --new-file v2.4.9/linux/drivers/video/sun3fb.c linux/drivers/video/sun3fb.c > --- v2.4.9/linux/drivers/video/sun3fb.c Thu Apr 26 22:17:27 2001 > +++ linux/drivers/video/sun3fb.c Mon Sep 17 22:52:35 2001 > @@ -586,9 +586,11 @@ > fb->cursor.hwsize.fbx = 32; > fb->cursor.hwsize.fby = 32; > > - if (depth > 1 && !fb->color_map) > + if (depth > 1 && !fb->color_map) { > fb->color_map = kmalloc(256 * 3, GFP_ATOMIC); > - > + return -ENOMEM; > + } > +
its a weird corruption of the patch that I had. Im not quite sure what has happened there. Lower down there is a random -ENODEV without a return too.
I'll dig out the originals and send Linus something sane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |