Messages in this thread |  | | Date | Thu, 30 Aug 2001 22:08:03 -0700 (PDT) | | From | Linus Torvalds <> | | Subject | Re: [IDEA+RFC] Possible solution for min()/max() war |
| |
On Thu, 30 Aug 2001, Ion Badulescu wrote: > > Really? How so? We _know_ that the result of sizeof() fits confortably within > "int"'s range. So the natural way to write that comparison would be > > if (len <= (int) sizeof(short) || len > (int) sizeof(*sunaddr))
You're so full of shit that it's incredible.
I'mnot going to argue this, when people call stuff like the above the "natural way". This is not worth it.
The fact is, the way gcc currently does things, -Wsign-compare is useless. Anybody who is honest would admit that. In order for the warning to become useful, gcc would need to do value range analysis - which people have been talking about, but which is not there yet.
There have been some constructive comments here (the automatic detection of bad comparisons etc), but yours is just stupid.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |