lkml.org 
[lkml]   [2001]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Patch]: incorrect e2fsprog data from ver_linux script
    Date
    On Thursday 30 August 2001 10:03 pm, Albert Cranford wrote:
    > Hello Alan/Linus,
    > Ted suggested I pass this onto your for 2.2 and 2.4
    > Please apply small patch to both releases.
    > Thanks,
    > Albert
    >
    >
    > -------- Original Message --------
    > Subject: incorrect e2fsprog data from ver_linux script
    > Date: Thu, 30 Aug 2001 10:08:27 -0400
    > From: Albert Cranford <ac9410@bellsouth.net>
    > To: tytso@valinux.com, tytso@mit.edu
    >
    > Hello Ted,
    > I'm not sure when incorrect e2fsprog info started popping
    > up from the linux/scripts/ver_linux script, but what do
    > you think about submitting this patch to Linus?
    > Later,
    > Albert
    >

    Hmm, this worked for e2fsprogs 1.22, e2fsprogs 1.23 was released
    8-15-01 according to Sourceforge.

    I applied your fix, and yes it now works for 1.23:

    [root@localhost linux]# sh scripts/ver_linux
    [irrelevant stuff snipped]
    modutils 2.4.3
    e2fsprogs 1.23
    reiserfsprogs 3.x.0i

    Ok, so far so good. Now checking ver_linux shipped with 2.4.9-ac5
    [root@localhost linux]# sh scripts/ver_linux.ac5
    [irrelevant stuff snipped]
    modutils 2.4.3
    e2fsprogs tune2fs
    reiserfsprogs 3.x.0i

    Yep, it's broken for e2fsprogs 1.23 all right.

    Now, I installed e2fsprogs 1.22, and your new version breaks:

    [root@localhost linux]# sh scripts/ver_linux <--- with your patch
    [irrelevant stuff snipped]
    modutils 2.4.3
    e2fsprogs tune2fs
    reiserfsprogs 3.x.0i

    and the old version (old as in 2.4.9-ac5) works for e2fsprogs 1.22
    [root@localhost linux]# sh scripts/ver_linux.ac5
    [irrelevant stuff snipped]
    modutils 2.4.3
    e2fsprogs 1.22
    reiserfsprogs 3.x.0i

    So, this patch breaks the ver_linux script for 1.22, and 1.21 (I checked
    this too). If someone wants to fix this right, please jump in.

    Steven
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:01    [W:0.045 / U:31.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site