lkml.org 
[lkml]   [2001]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PROBLEM: usb not working with 2.4.8-ac8
On Fri, Aug 24, 2001, Pete Zaitcev <zaitcev@redhat.com> wrote:
> > What was you test scenario where you didn't see a completion callback?
>
> The root hub emulation never posts one.

Hmm, it should. I'll check that again.

> > > + if (ret == 0) { /* N.B. Done, must notify */
> > > + /* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */
> > > + urb->dev = NULL;
> > > + if (urb->complete)
> > > + urb->complete(urb);
> > > + }
> > >
> > > - usb_dec_dev_use(urb->dev);
> > > + usb_dec_dev_use(dev);
>
> > What's all of this for? Protecting against an urb->dev race condition?
>
> No race, but we cannot use urb after callback.

Ahh, good point.

Thanks.

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:58    [W:0.055 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site