lkml.org 
[lkml]   [2001]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: /dev/random entropy calcs - patch [not related to net devices]
Date

> + time = (__u32)(xtime.tv_usec) ^ (__u32)(xtime.tv_sec);

I would prefer:

time = (__u32)xtime.tv_usec | ( (__u32)(xtime.tv_sec)<<20) );

The way you have it, you collide the two least-significant bits,
potentially losing some entropy.

DS

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:57    [W:0.033 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site