Messages in this thread |  | | From | (Eugene Crosser) | Subject | Re: Patch for bizzare oops in USB | Date | 21 Aug 2001 02:12:35 +0400 |
| |
In article <3B80FBA9.556B7B2B@scs.ch>, Thomas Sailer <sailer@scs.ch> writes:
>> --- linux-2.4.8/drivers/usb/usb.c Tue Jul 24 14:20:56 2001 >> +++ linux-2.4.8-e/drivers/usb/usb.c Fri Aug 17 22:03:27 2001 >> @@ -1066,7 +1066,7 @@ >> >> awd.wakeup = &wqh; >> init_waitqueue_head(&wqh); >> - current->state = TASK_INTERRUPTIBLE; >> + current->state = TASK_UNINTERRUPTIBLE; /* MUST BE SO. -- zaitcev */ >> add_wait_queue(&wqh, &wait); >> urb->context = &awd; >> status = usb_submit_urb(urb); > > This is bad for other users of usb_control_msg/usb_bulk_msg that depend on > the sleep to be interruptible. Instead of bouncing back and forth whether > those routines shall sleep interruptibly or uninterruptibly, we should either > provide two routines or a parameter that specifies whether the sleep > shall be interruptible, or create a local version of usb_control_msg > if ov511 is the only user requiring uninterruptible sleep.
I observe similar Oops with D-Link USB radio tuner on uhci when I hit Ctrl-C (SMP system, UP system with ohci works). I was preparing to post ksymoops report when I read Pete's message ;)
Eugene - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |