lkml.org 
[lkml]   [2001]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectPATCH - One line AWE32 driver bug fix.

KERNEL:
Version 2.4.9 (Applies to 2.2.x kernels too)

DESCRIPTION:
The sound blaster awe32 wave driver has for as long as I can remember
(back to 2.2.4?) unreliably detected the on-board ram size for awe32
and awe64 cards. Having looked at the code this was an obvious mistake
in the choice of constant. The author chose a number of 0xFFFF which is
written to the card and then read if the value read equals "0xFFFF" then
the write was assumed to be succeful and the driver increments a bit and
trys again. Unfortunately reading from a port which has no hardware by
default (I think) returns 0xFFFF. Meaning the scan often ran off the
end of the memory. Changing the value to 0xABCD seems to produce 100%
reliable memory size detection.


Hope to see this in the kernel soon to save me doing it each time I
download it!!

Dave Fennell.
Dave@NetReady.ltd.uk

PATCH FOLLOWS:

--- drivers/sound/awe_wave.c.orig Tue Aug 21 00:35:33 2001
+++ drivers/sound/awe_wave.c Tue Aug 21 00:36:26 2001
@@ -4873,7 +4873,7 @@
/* any three numbers you like */
#define UNIQUE_ID1 0x1234
#define UNIQUE_ID2 0x4321
-#define UNIQUE_ID3 0xFFFF
+#define UNIQUE_ID3 0xABCD

static void __init
awe_check_dram(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:57    [W:0.034 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site