lkml.org 
[lkml]   [2001]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] zero-bounce highmem I/O
On Wed, Aug 15 2001, David S. Miller wrote:
> From: "David S. Miller" <davem@redhat.com>
> Date: Wed, 15 Aug 2001 07:02:04 -0700 (PDT)
>
> > Yep. Want me to add in the x86 parts of your patch?
> >
> > Please let me finish up my prototype with sparc64 building and
> > working, then I'll send you what I have ok?
>
> Fine
>
> This is forthcoming.
>
> As promised. I actually got bored during the build and tried to

Looks good! And works here too, even... ->

> quickly cook up the ix86 bits myself :-)

the boring x86 parts :-)

The only difference between your and my tree now is the PCI_MAX_DMA32
flag. Would you consider this? I already use this flag in the block
stuff, I just updated the two references you had. Maybe
PCI_MAX_DMA32_MASK is a better name.

I'll update the block-highmem patch later today -- and with this in
place, there's nothing stopping zero-bounce from going beyond 4GB on the
right hw. Yippi.

--- linux/include/linux/pci.h~ Thu Aug 16 13:40:32 2001
+++ linux/include/linux/pci.h Thu Aug 16 13:41:11 2001
@@ -314,6 +314,8 @@
#define PCI_DMA_FROMDEVICE 2
#define PCI_DMA_NONE 3

+#define PCI_MAX_DMA32 0xffffffff
+
/* These are the boolean attributes stored in pci_dev->dma_flags. */
#define PCI_DMA_FLAG_HUGE_MAPS 0x00000001 /* Device may hold an enormous number
* of mappings at once?
--- linux/drivers/scsi/sym53c8xx.c~ Thu Aug 16 13:42:27 2001
+++ linux/drivers/scsi/sym53c8xx.c Thu Aug 16 13:42:50 2001
@@ -13101,7 +13101,7 @@
(int) (PciDeviceFn(pdev) & 7));

#ifdef SCSI_NCR_DYNAMIC_DMA_MAPPING
- if (pci_set_dma_mask(pdev, 0xffffffff)) {
+ if (pci_set_dma_mask(pdev, PCI_MAX_DMA32)) {
printk(KERN_WARNING NAME53C8XX
"32 BIT PCI BUS DMA ADDRESSING NOT SUPPORTED\n");
return -1;
--- linux/drivers/scsi/sym53c8xx_comm.h~ Thu Aug 16 13:43:09 2001
+++ linux/drivers/scsi/sym53c8xx_comm.h Thu Aug 16 13:43:32 2001
@@ -2186,7 +2186,7 @@
(int) (PciDeviceFn(pdev) & 7));

#ifdef SCSI_NCR_DYNAMIC_DMA_MAPPING
- if (!pci_dma_supported(pdev, 0xffffffff)) {
+ if (!pci_dma_supported(pdev, PCI_MAX_DMA32)) {
printk(KERN_WARNING NAME53C8XX
"32 BIT PCI BUS DMA ADDRESSING NOT SUPPORTED\n");
return -1;
--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site