Messages in this thread | | | Date | Fri, 17 Aug 2001 03:24:05 +0200 | From | Roman Zippel <> | Subject | Re: 2.4.9 does not compile [PATCH] |
| |
Hi,
"David S. Miller" wrote:
> IMHO, it would have been more elegant to use the typeof construct provided > by gcc in the new macro instead of introducing a type parameter like this... > > The whole point was to make users explicitly state the type so they > would have to think about it.
I have two problems with this: 1. They maybe think once about it, but are they doing it a second time? If the type of the argument is changed somewhere in the header, the min argument is easily missed, since... 2. This macro doesn't produce a warning like the typeof version does. The typeof version warns you about signed/unsigned compares, while an assignment gives no warning.
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |