lkml.org 
[lkml]   [2001]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patches in this message
/
Date
From
SubjectRe: [PATCH] parport_pc.c PnP BIOS sanity check
Alan Cox wrote:
> IRQ 0 is a legal valid IRQ. I suspect the problem is that pnpbios shouldnt
> be reporting an IRQ or we should be using some kind of NO_IRQ cookie

Okay, I accept that. Then must we also say that DMA 0 is a
valid DMA? If so, then unless I'm confused about something
the rejection of dma==0 should be eliminated:
--------------------------------------------------------------------------------
--- linux-2.4.7-ac10/drivers/parport/parport_pc.c_ORIG Fri Aug 10 18:19:07 2001
+++ linux-2.4.7-ac10/drivers/parport/parport_pc.c Mon Aug 13 17:40:38 2001
@@ -2797,8 +2797,6 @@
irq=dev->irq_resource[0].start;
dma=dev->dma_resource[0].start;

- if (dma==0) dma=-1;
-
printk(KERN_INFO "PnPBIOS: Parport found %s %s at io=%04x,%04x irq=%d dma=%d\n",
dev->name,dev->slot_name,io,iohi,irq,dma);
if (parport_pc_probe_port(io,iohi,irq,dma,NULL))
--------------------------------------------------------------------------------
Otherwise I think the following change should be made for the sake of
code clarity. (PARPORT_DMA_NONE is defined as -1.)
--------------------------------------------------------------------------------
--- linux-2.4.7-ac10/drivers/parport/parport_pc.c_ORIG Fri Aug 10 18:19:07 2001
+++ linux-2.4.7-ac10/drivers/parport/parport_pc.c Fri Aug 10 18:19:55 2001
@@ -2797,7 +2797,7 @@
irq=dev->irq_resource[0].start;
dma=dev->dma_resource[0].start;

- if (dma==0) dma=-1;
+ if (dma==0) dma=PARPORT_DMA_NONE;

printk(KERN_INFO "PnPBIOS: Parport found %s %s at io=%04x,%04x irq=%d dma=%d\n",
dev->name,dev->slot_name,io,iohi,irq,dma);
--------------------------------------------------------------------------------
--
Thomas Hood
jdthood_AT_yahoo.co.uk--- linux-2.4.7-ac10/drivers/parport/parport_pc.c_ORIG Fri Aug 10 18:19:07 2001
+++ linux-2.4.7-ac10/drivers/parport/parport_pc.c Mon Aug 13 17:40:38 2001
@@ -2797,8 +2797,6 @@
irq=dev->irq_resource[0].start;
dma=dev->dma_resource[0].start;

- if (dma==0) dma=-1;
-
printk(KERN_INFO "PnPBIOS: Parport found %s %s at io=%04x,%04x irq=%d dma=%d\n",
dev->name,dev->slot_name,io,iohi,irq,dma);
if (parport_pc_probe_port(io,iohi,irq,dma,NULL))--- linux-2.4.7-ac10/drivers/parport/parport_pc.c_ORIG Fri Aug 10 18:19:07 2001
+++ linux-2.4.7-ac10/drivers/parport/parport_pc.c Fri Aug 10 18:19:55 2001
@@ -2797,7 +2797,7 @@
irq=dev->irq_resource[0].start;
dma=dev->dma_resource[0].start;

- if (dma==0) dma=-1;
+ if (dma==0) dma=PARPORT_DMA_NONE;

printk(KERN_INFO "PnPBIOS: Parport found %s %s at io=%04x,%04x irq=%d dma=%d\n",
dev->name,dev->slot_name,io,iohi,irq,dma);
\
 
 \ /
  Last update: 2005-03-22 12:57    [W:0.061 / U:2.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site