Messages in this thread |  | | Date | Mon, 2 Jul 2001 09:25:50 +0100 (BST) | | From | Riley Williams <> | | Subject | Re: [PATCH] Re: 2.4.6p6: dep_{bool,tristate} $CONFIG_ARCH_xxx bugs |
| |
Hi Keith.
>> Q> dep_arch_tristate ' AM79C961A support' CONFIG_ARM_AM79C961A \ >> Q> "$CONFIG_ARCH_ACORN" $CONFIG_NET_ETHERNET
>> That adds only two extra characters, neither conspicuous, and >> PASSES my code.
> It relies on everybody writing new dep_arch_... rules to > remember the quotes. You are just introducing another source of > human error. That is how this mess occurred, no automatic > validation of input.
OK then, a simple change to the patch I submitted, and the following instead...
Q> dep_arch_tristate ' AM79C961A support' CONFIG_ARM_AM79C961A \ Q> ACORN $CONFIG_NET_ETHERNET
The enclosed patch implements this syntax, and CHECKS that the syntax stated has been supplied, for both `make config` and `make menuconfig` and I would imagine the same would be easily added to `make xconfig` and `make checkconfig` as well by those fluent in the relevant languages.
Note specifically that it requires that the CONFIG_ARCH_ part of the name of the variable is NOT provided, and as a result requires that config variables naming the architecture begin with that string.
Best wishes from Riley. [unhandled content-type:application/x-gzip] |  |