lkml.org 
[lkml]   [2001]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH] ppp_generic.c: last_channel_index
Date
I found that after I repeatedly opened and closed PPP connections, I would
get an Oops. PPP daemon would try to allocate strange PPP interface numbers
(ppp12, for example) and other sanity checks would fail (kind != INTERFACE
|| CHANNEL)

The last_channel_index wasn't being cleaned up when the channel was closed,
leading to these problems the next time a PPP channel was opened. This
patch fixes the problem for me.

using ppp-2.4.0, patch against: linux-2.4.6

Regards,
Brian

*** ppp_generic.c Sun Apr 22 09:46:40 2001
--- /home/brian/linux/drivers/net/ppp_generic.c Fri Jul 13 18:38:30 2001
***************
*** 1871,1876 ****
--- 1796,1802 ----
ppp_disconnect_channel(pch);
wake_up_interruptible(&pch->file.rwait);
spin_lock_bh(&all_channels_lock);
+ last_channel_index--;
list_del(&pch->file.list);
spin_unlock_bh(&all_channels_lock);
if (atomic_dec_and_test(&pch->file.refcnt))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:57    [W:0.035 / U:2.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site