[lkml]   [2001]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] minor fixup of quota checking
The following patch fixes (I think) an error in the boolean logic for
checking if a filesystem can support quotas. Since quotas use both
read and write file operations, we need both functions available, but
the current test only fails if both read and write are NOT available.

Cheers, Andreas
diff -ru linux-2.4.6.orig/fs/dquot.c linux-2.4.6-aed/fs/dquot.c
--- linux-2.4.6.orig/fs/dquot.c Thu Jun 28 14:28:23 2001
+++ linux-2.4.6-aed/fs/dquot.c Thu Jun 28 14:27:23 2001
@@ -1467,7 +1467,7 @@
if (IS_ERR(f))
goto out_lock;
error = -EIO;
- if (!f->f_op || (!f->f_op->read && !f->f_op->write))
+ if (!f->f_op || !f->f_op->read || !f->f_op->write)
goto out_f;
inode = f->f_dentry->d_inode;
error = -EACCES;
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?" -- Dogbert
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at
 \ /
  Last update: 2005-03-22 12:56    [W:0.043 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site