lkml.org 
[lkml]   [2001]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] Re: Linux 2.4.5-ac6
On Fri, 8 Jun 2001, Ivan Kokshaysky wrote:

> No. I've changed in load_aout_binary() set_personality(PER_LINUX) to
> set_personality(PER_LINUX_32BIT), and now I have another error.
> You will laugh, but...
>
> $ netscape
> 665:/usr/lib/netscape/netscape-communicator: : Fatal Error: mmap available address is not larger than requested
>
> This happens after
> mmap(0x7fdc8000, 40960, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40018000
>
> And note, this is the message from loader, not from netscape itself.

Oh well, so they cheat -- they claim in their docs the kernel may choose
whatever address it considers appropriate and then rely on particular
behaviour. What for, I wonder... I guess they weren't able to resolve
signedness issues...

> So I think my second patch is an easiest solution for now.
> Look, compared with the code in Linus' tree:
> - it doesn't add any overhead in general case (addr == 0);
> - if the specified address is too high and we can't find a free
> area above it, we just continue search from TASK_UNMAPPED_BASE
> as usual;
> - if address is too low, extra cost is only compare and taken branch.

That's all fine, but...

> I think it's clean enough.

Still it has two loops... I'm not sure how to eliminate one of them at
the moment, though. I think we might also consider moving the
compatibility crap into arch/alpha/kernel.

--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:55    [W:0.071 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site