lkml.org 
[lkml]   [2001]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Re: BUG: race-cond with partition-check
    From COTTE@de.ibm.com Fri Jun  8 09:57:01 2001

>Well, among the irrelevant details you left out is the fact that
>it is not
> blk_size[dev->major] =3D NULL;
>but
> if(!dev->sizes)
> blk_size[dev->major] =3D NULL;

Well, this is absoloutely right, the behaviour to clear blk_size
when dev->sizes
is NULL looks sensible to me. But seven lines below it says
-unconditionaly-:
blk_size[dev->major] =3D NULL;

Ah, yes. This second assignment can just be deleted, I suppose.

--- partitions/check.c~ Thu May 31 22:26:56 2001
+++ partitions/check.c Fri Jun 8 10:44:02 2001
@@ -418,11 +418,10 @@
blk_size[dev->major] = NULL;

dev->part[first_minor].nr_sects = size;
- /* No Such Agen^Wdevice or no minors to use for partitions */
+ /* No such device or no minors to use for partitions */
if (!size || minors == 1)
return;

- blk_size[dev->major] = NULL;
check_partition(dev, MKDEV(dev->major, first_minor), 1 + first_minor);

/*
[In the good old days it wasn't there. It was added in 1.3.19,
don't know why, probably as a safeguard to make sure nobody
used these values while they are being set up. But someone
was bit by the assignment, since it is not undone if we take
the return, so in 2.3.48 the assignment was moved past the
return, with a conditional assignment before it. I believe
you are right, and we only want the conditional assignment.]

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:55    [W:0.029 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site