lkml.org 
[lkml]   [2001]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] rio500 devfs support
    Gregory T. Norris writes:
    >
    > --qlTNgmc+xy1dBmNv
    > Content-Type: multipart/mixed; boundary="0F1p//8PRICkK4MW"
    > Content-Disposition: inline

    Yuk! MIME!

    > --0F1p//8PRICkK4MW
    > Content-Type: text/plain; charset=us-ascii
    > Content-Disposition: inline
    > Content-Transfer-Encoding: quoted-printable

    Horrors! Quoted-printables!

    > Here's an updated version of the patch - the only real difference is
    > that rio500.c will printk an error message if devfs_register() fails.=20
    > I left that out originally because devfs logs the error, but it's
    > probably a good idea to indicate which driver made the request.

    No, it's a bad idea to test the error from devfs_register() unless you
    *really* have a good reason. Most people who think they have a good
    reason actually don't, they're just confused :-)

    The reason you don't want to test the return value is that way the
    driver works fine with CONFIG_DEVFS=n. Otherwise, you have a driver
    that doesn't work with devfs, or you have to put ugly #ifdef's in the
    code.

    Regards,

    Richard....
    Permanent: rgooch@atnf.csiro.au
    Current: rgooch@ras.ucalgary.ca
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:55    [W:0.021 / U:0.340 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site