lkml.org 
[lkml]   [2001]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] catch potential null derefs in drivers/char/ip2main.c (245ac16)
On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
[...]
> I'm responsible for the kernel / driver integration end of it
> anyways.
>
> I'll find out what's up with Doug, but this is my issue to deal
> with anyways. And yes, I'm looking at it. I've got a couple of other
> patches on the back burner that are overdue for integration.

The pB deref below kinda bothers me. It is last set way above as
part of looping through stuff comparing it to NULL. It seems
bogus to use is as below but I have no clue what should be used
instead.

[..]
> > - for ( box = 0; box < ABS_MAX_BOXES; ++box )
> > - {
> > - for ( j = 0; j < ABS_BIGGEST_BOX; ++j )
> > - {
> > - if ( pB->i2eChannelMap[box] & (1 << j) )
> > + for ( box = 0; box < ABS_MAX_BOXES; ++box )
> > {

Regards,
Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:55    [W:0.041 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site