Messages in this thread | | | Date | Mon, 18 Jun 2001 00:40:21 -0600 | From | Richard Gooch <> | Subject | Re: [PATCH] devfs v181 available |
| |
Alexander Viro writes: > > > On Mon, 18 Jun 2001, Richard Gooch wrote: > > > - Widened locking in <devfs_readlink> and <devfs_follow_link> > > No, you hadn't. Both vfs_readlink() and vfs_follow_link() are blocking > functions, so BKL is worthless there.
Huh? The BKL will protect against other operations which might cause the devfs entry to be unregistered, where those other operations also grab the BKL. So, it's an improvement.
Sure, some operations may cause unregistration without grabbing the BKL, but that's orthogonal (and requires more extensive changes). If this "widening" is of no use, then what use are the existing grabs of the BKL in those functions? You're the one who added them in the first place.
Regards,
Richard.... Permanent: rgooch@atnf.csiro.au Current: rgooch@ras.ucalgary.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |