Messages in this thread | | | Date | Thu, 31 May 2001 00:24:37 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] net #6 |
| |
Hi!
> They are neccessary > > > @@ -643,9 +631,7 @@ > > eexp_hw_tx_pio(dev,data,length); > > } > > dev_kfree_skb(buf); > > -#ifdef CONFIG_SMP > > spin_unlock_irqrestore(&lp->lock, flags); > > -#endif > > enable_irq(dev->irq); > > return 0; > > They are done this way to get good non SMP performance. Your changes would > ruin that.
Maybe macro "spin_lock_irqsave_on_smp()" would be good idea? These ifdefs look ugly. Maybe local to driver, maybe even global. Pavel -- I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care." Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |