lkml.org 
[lkml]   [2001]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] save source address on accept()

Tim Hockin writes:
> attached is a (small) patch which saves the src address on tcp_accept().
> Please let me know if there are any problems taking this for general
> inclusion.
..
> --- dist-2.4.5/net/ipv4/tcp.c Wed May 16 10:31:27 2001
> +++ cobalt-2.4.5/net/ipv4/tcp.c Thu May 31 14:33:23 2001
> @@ -2138,6 +2138,7 @@
> tp->accept_queue_tail = NULL;
>
> newsk = req->sk;
> + newsk->rcv_saddr = req->af.v4_req.loc_addr;
> tcp_acceptq_removed(sk);
> tcp_openreq_fastfree(req);
> BUG_TRAP(newsk->state != TCP_SYN_RECV);

Tim, this is in fact completely bogus, it is already being done
in tcp_v{4,6}_syn_recv_sock(), so there is no reason to do the
exact same thing again here in tcp_accept().

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:54    [W:0.040 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site