lkml.org 
[lkml]   [2001]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net
> > @@ -643,9 +631,7 @@ 
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.

I think the spin_lock could be removed on SMP, too.

Concurrent xmit & timeout calls are prevented by core network code, and
concurrent interrupts are prevented by disable_irq().

Or replace spin_lock_irqsave() with spin_lock().

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:54    [W:0.020 / U:1.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site