lkml.org 
[lkml]   [2001]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] net #6
    Date
    > 
    > > The following patch removes unnecessary #ifdefs from eexpress.c
    >
    > They are neccessary

    Yes, you are right.
    I was suggested by improper part of spinlock.h ...

    Forget this patch.

    > > @@ -643,9 +631,7 @@
    > > eexp_hw_tx_pio(dev,data,length);
    > > }
    > > dev_kfree_skb(buf);
    > > -#ifdef CONFIG_SMP
    > > spin_unlock_irqrestore(&lp->lock, flags);
    > > -#endif
    > > enable_irq(dev->irq);
    > > return 0;
    >
    > They are done this way to get good non SMP performance. Your changes would
    > ruin that.

    --
    =======================================================================
    Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl
    tel. (0-58) 347 14 61
    Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:54    [W:0.021 / U:87.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site