lkml.org 
[lkml]   [2001]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: iso9660 endianness cleanup patch
Hi!

> > > The attached patch fixes both. It is against 2.4.4, but from the looks
> > > of it it should patch against -ac as well.
> >
> > Btw, please use "static inline" instead of "extern inline", as gcc may
> > decide not to inline the latter at all, leading to confusing link-time
> > errors. (Gcc may also decide not to inline "static inline", but then gcc
> > will output the actual body of the function out-of-line if it gets used,
> > so you don't get the link-time failure).
> >
> > Right now only certain broken versions of gcc will actually show this
> > behaviour, I think, but it's at least in theory going to be an issue.
> >
>
> I guess I personally prefer an error over completely broken behaviour,
> but feel free to change it.

It should ot break anything. gcc decides its bad to inline it, so it
does not inline it. Small code growth at worst. Compiler has right to
make your code bigger or slower, if it decides to do so.
--
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.061 / U:3.052 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site