lkml.org 
[lkml]   [2001]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] warning fixes for 2.4.5pre5
Date
On Friday 25 May 2001 11:10 am, Alan Cox wrote:
> > This patch has been tested and the code does compile.
> >
> > Rich
> >
> > diff -urN -X /linux/dontdiff linux/arch/i386/math-emu/fpu_trig.c
> > rb/arch/i386/math-emu/fpu_trig.c
> > --- linux/arch/i386/math-emu/fpu_trig.c Fri Apr 6 12:42:47 2001
> > +++ rb/arch/i386/math-emu/fpu_trig.c Tue May 22 16:44:57 2001
> > @@ -1543,6 +1543,7 @@
> > EXCEPTION(EX_INTERNAL | 0x116);
> > return;
> > #endif /* PARANOID */
> > + return;
>
> This seems to be a change in behaviour. Have you done a glibc fpu test on
> the changes ?

I used objdump on the fpu_trig.o files in both trees and they do differ.
When I use break instead of return in my tree the two files are the same.
Here is a revised patch that fixes the warning and produces the same assembly
code code as the version in Linus' tree.


diff -urN -X /linux/dontdiff linux/arch/i386/math-emu/fpu_trig.c
rb/arch/i386/math-emu/fpu_trig.c
--- linux/arch/i386/math-emu/fpu_trig.c Fri Apr 6 12:42:47 2001
+++ rb/arch/i386/math-emu/fpu_trig.c Tue May 22 16:44:57 2001
@@ -1543,6 +1543,7 @@
EXCEPTION(EX_INTERNAL | 0x116);
return;
#endif /* PARANOID */
+ break;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:53    [W:0.042 / U:2.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site