Messages in this thread |  | | Date | Fri, 25 May 2001 23:11:23 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16) |
| |
On Fri, May 25 2001, Rasmus Andersen wrote: > (I forgot to cc l-k on this one when it went to andre.) > > Hi. > > This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as > reported by the Stanford team way back. It applies against 244ac16. > > > --- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001 > +++ linux-244-ac16/drivers/ide/ide.c Fri May 25 22:46:43 2001 > @@ -2362,6 +2362,8 @@ > __restore_flags(lflags); /* local CPU only */ > spin_lock_irq(&io_request_lock); > } > + > + spin_unlock_irq(&io_request_lock); > return 0; > }
This isn't right. Granted the locking isn't straight forward here, but take a look at ide_write_setting -> ide_spin_wait_hwgroup and the latters return value.
BTW, also try and follow local style when making such changes.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |