lkml.org 
[lkml]   [2001]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: alpha iommu fixes
Andrea Arcangeli wrote:
>
> On Sun, May 20, 2001 at 03:49:58PM +0200, Andrea Arcangeli wrote:
> > they returned zero. You either have to drop the skb or to try again later
> > if they returns zero.
>
> BTW, pci_map_single is not a nice interface, it cannot return bus
> address 0, so once we start the fixage it is probably better to change
> the interface as well to get either the error or the bus address via a
> pointer passed to the function.
>

Would it not be sufficient to define a machine-specific
macro which queries it for error? On x86 it would be:

#define BUS_ADDR_IS_ERR(addr) ((addr) == 0)

I can't find *any* pci_map_single() in the 2.4.4-ac9 tree
which can fail, BTW.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:53    [W:0.148 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site