Messages in this thread |  | | From | Andrzej Krzysztofowicz <> | Subject | Re: [PATCH] 2.4.4-ac11 network drivers cleaning | Date | Sun, 20 May 2001 15:35:35 +0200 (CEST) |
| |
> > On Sat, 19 May 2001 17:58:49 -0400, > Jeff Garzik <jgarzik@mandrakesoft.com> wrote: > >Finally, I don't know if I mentioned this earlier, but to be complete > >and optimal, version strings should be a single variable 'version', such > >that it can be passed directly to printk like > > > > printk(version); > > Nit pick. That has random side effects if version contains any '%' > characters. Make it
It should not. I see no reason for a literal % in the version string.
> > printk("%s\n", version); > > Not quite as optimal but safer.
It is simpler to remove the %s from version. I don't think any of them require it. If one add a % he should know what he is doing.
-- ======================================================================= Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl tel. (0-58) 347 14 61 Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |