lkml.org 
[lkml]   [2001]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: 2.4.4, 2.4.4-ac1 and -ac3: oops loading future domain scsi module
On Wed, May 02, 2001 at 09:03:59AM +0200, Carlo E. Prelz wrote:

> Subject: 2.4.4, 2.4.4-ac1 and -ac3: oops loading future domain scsi module
> Date: Wed, May 02, 2001 at 08:30:18AM +0200
>
> Quoting Carlo E. Prelz (fluido@fluido.as):
>
> > Here I am with another, fresh oops that I encountered while exploring
> > new kernels. This time, the oops is generated when trying to load the
> > module for a very old (1993) Future Domain SCSI card. 2.4.3-ac7 was my
> > previous kernel and worked perfectly.
>
> I made some more research. Eventually, it seems the problem is in this
> patch that was included in 2.4.4:
>
> @@ -969,6 +971,7 @@
> return 0;
> shpnt->irq = interrupt_level;
> shpnt->io_port = port_base;
> + scsi_set_pci_device(shpnt->pci_dev, pdev);
> shpnt->n_io_port = 0x10;
> print_banner( shpnt );
>
> Well, but my card is ISA! It should not set any PCI device.
>
> I applied the following patch, and the problem disappeared:
>
> --- fdomain.c~ Wed May 2 07:08:27 2001
> +++ fdomain.c Wed May 2 08:58:03 2001
> @@ -971,6 +971,7 @@
> return 0;
> shpnt->irq = interrupt_level;
> shpnt->io_port = port_base;
> + if(pdev!=NULL)
> scsi_set_pci_device(shpnt->pci_dev, pdev);
> shpnt->n_io_port = 0x10;
> print_banner( shpnt );
>
> I hope this is the right way...

Well I got the same oops with a PCI card...
After some research I found that the first argument to the inline
function scsi_set_pci_device is supposed to be a pointer to a
struct Scsi_Host.
The patch below should work for both ISA and PCI.

Regards
/Martin


--- fdomain.c.orig Wed May 2 13:33:09 2001
+++ fdomain.c Wed May 2 14:04:45 2001
@@ -971,7 +971,7 @@
return 0;
shpnt->irq = interrupt_level;
shpnt->io_port = port_base;
- scsi_set_pci_device(shpnt->pci_dev, pdev);
+ scsi_set_pci_device(shpnt, pdev);
shpnt->n_io_port = 0x10;
print_banner( shpnt );


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.044 / U:3.852 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site