lkml.org 
[lkml]   [2001]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] 2.4.5pre3 warning fixes
Date
Looks to me like it's adding { and } on each side of the
"c->devices->prev=d;" statement... so changing from:

if (c->devices != NULL)
c->devices->prev=d;

to

if (c->devices != NULL){
c->devices->prev=d;
}

I assume the new compiler likes the if to have explicit brackets instead of
using the next statement...

Sam Bingner

-----Original Message-----
From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk]
Sent: Thursday, May 17, 2001 9:40 AM
To: richbaum@acm.org
Cc: linux-kernel@vger.kernel.org; torvalds@transmeta.com;
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] 2.4.5pre3 warning fixes


> --- linux/drivers/i2o/i2o_core.c Thu May 17 11:38:28 2001
> +++ rb/drivers/i2o/i2o_core.c Thu May 17 11:48:08 2001
> @@ -380,8 +380,9 @@
> d->owner=NULL;
> d->next=c->devices;
> d->prev=NULL;
> - if (c->devices != NULL)
> + if (c->devices != NULL){
> c->devices->prev=d;
> + }

What does this have to do with gcc compiler warnings ?????

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:53    [W:0.043 / U:12.452 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site