Messages in this thread |  | | Date | Tue, 15 May 2001 11:57:14 -0700 | From | Jonathan Lundell <> | Subject | Re: [PATCH] Remove silly beep macro from pgtable.h |
| |
At 7:36 PM +0200 2001-05-15, Mike Galbraith wrote: >On Tue, 15 May 2001, Jeff Golds wrote: > >> Hi folks, >> >> Found this bit of unused code in the i386 and sh architectures. >>As it's not being used, let's get rid of it. Also, pgtable.h seems >>to be an odd place for this. > >I'd leave it.. folks with early boot troubles might find it useful. > > -Mike
Consider small rant about literal IO references to magic locations hereby ranted. Especially in header files completely unrelated to the IO function in question.
-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")
Let's please not assume that every i386 implementation has a full set of legacy PC IO hardware. -- /Jonathan Lundell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |