lkml.org 
[lkml]   [2001]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] filemap.c fixes
On Mon, 14 May 2001, Linus Torvalds wrote:

> > > > + if (PageActive(page))
> > > > + SetPageReferenced(page);
> > > > + else
> > > > + activate_page(page);

> Now, please explain to me why it's not just a simple
>
> SetPageReferenced(page);
>
> and then just moving it lazily from one queue to another..

This might get us into problems when we think we have enough
inactive pages to take the next load spike, but we don't.

On the other hand, that's a theoretical situation and I don't
think we'll hit that in practice ... at least, not in workloads
we'd be able to deal nicely with in any way.

Just going with the simple version should work.

regards,

Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

http://www.surriel.com/ http://distro.conectiva.com/

Send all your spam to aardvark@nl.linux.org (spam digging piggy)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:53    [W:0.037 / U:6.672 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site