This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Tue Apr 16 17:17:59 2024 Received: from spaans.ds9a.nl (adsl-xs4all.ds9a.nl [213.84.159.51]) by kylie.puddingonline.com (8.11.6/8.11.6) with SMTP id g8ID4cX23343 for ; Wed, 18 Sep 2002 15:04:38 +0200 Received: (qmail 27723 invoked from network); 18 Sep 2002 06:41:08 -0000 Received: from unknown (HELO spaans.ds9a.nl) (3ffe:8280:10:360:202:44ff:fe2a:a1dd) by mayo.ipv6.ds9a.nl with SMTP; 18 Sep 2002 06:41:08 -0000 Received: (qmail 2339 invoked by uid 1000); 17 Sep 2002 20:14:12 -0000 Received: (maildatabase); juh Received: (qmail 10266 invoked by alias); 14 May 2001 20:59:32 -0000 Received: (qmail 10263 invoked from network); 14 May 2001 20:59:31 -0000 Received: from vger.kernel.org (199.183.24.194) by spaans-smp.ds9a.tudelft.nl with SMTP; 14 May 2001 20:59:31 -0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 14 May 2001 16:57:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 14 May 2001 16:57:12 -0400 Received: from gso56-168-043.triad.rr.com ([66.56.168.43]:65158 "EHLO hlclabs.dynip.com") by vger.kernel.org with ESMTP id ; Mon, 14 May 2001 16:57:09 -0400 Received: from hlclabs.dynip.com (IDENT:mike@rotor [192.168.1.1]) by hlclabs.dynip.com (8.9.3/8.9.3) with SMTP id RAA06624; Mon, 14 May 2001 17:07:33 -0400 Content-Type: text/plain; charset="iso-8859-1" From: Mike Harmon Organization: Harmon Liles Computer Labs To: torvalds@transmeta.com Subject: [PATCH] Future Domain SCSI controller fix for 2.4.x Date: Mon, 14 May 2001 17:07:32 -0400 X-Mailer: KMail [version 1.2] Cc: linux-kernel@vger.kernel.org, faith@cs.unc.edu, linux-scsi@vger.kernel.org Mime-Version: 1.0 Message-Id: <01051417073200.06553@hlclabs.dynip.com> Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org Hi, the driver for this card seems to have missed out on one of the changes to the SCSI layer between 2.2 and 2.4. Specifically, scsi_set_pci_device now wants an entire SCSI host object, instead of just the pci_dev part. Without the patch, we get a null kernel pointer dereference when the driver is initialized. With the single-line update, the driver works again. I've also included a patch to change an udelay loop into the equivalent mdelay call for code readability purposes. These are both against 2.4.4; please apply. -- Email: mikeharmon@usa.net --- linux-2.4.4/drivers/scsi/fdomain.old Mon May 14 16:33:11 2001 +++ linux-2.4.4/drivers/scsi/fdomain.c Fri May 4 11:07:41 2001 inline static void fdomain_make_bus_idle( void ) @@ -971,7 +969,7 @@ return 0; shpnt->irq = interrupt_level; shpnt->io_port = port_base; - scsi_set_pci_device(shpnt->pci_dev, pdev); + scsi_set_pci_device(shpnt, pdev); shpnt->n_io_port = 0x10; print_banner( shpnt ); --- linux-2.4.4/drivers/scsi/fdomain.old Mon May 14 16:33:11 2001 +++ linux-2.4.4/drivers/scsi/fdomain.c Fri May 4 11:07:41 2001 @@ -587,9 +587,7 @@ static void do_pause( unsigned amount ) /* Pause for amount*10 milliseconds */ { - do { - udelay(10*1000); - } while (--amount); + mdelay(10*amount); } 2@2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/