lkml.org 
[lkml]   [2001]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] vmalloc NULL Check Bug Fix
Hello!

I'm Philip, from Professor Dawson Engler's Meta-Compilation Group at
Stanford University.

This simple and obvious bug fix makes sure that vmalloc() does not return
NULL. My addition of returning -1 is consistent with how the rest of the
code deals with allocation failures.

Warmly,

Philip

---drivers/mtd/ftl.c Fri Feb 9
11:30:23 2001
+++ ftl.c Sun May 13 00:25:26 2001
@@ -375,6 +375,8 @@
/* Set up virtual page map */
blocks = le32_to_cpu(header.FormattedSize) >> header.BlockSize;
part->VirtualBlockMap = vmalloc(blocks * sizeof(u_int32_t));
+ if(!part->VirtualBlockMap) return -1;
+
memset(part->VirtualBlockMap, 0xff, blocks * sizeof(u_int32_t));
part->BlocksPerUnit = (1 << header.EraseUnitSize) >> header.BlockSize;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.025 / U:2.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site