lkml.org 
[lkml]   [2001]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] winbond-840 update
Jeff Garzik wrote:
>
> Manfred Spraul wrote:
> > @@ -437,9 +439,9 @@
> > if (option > 0) {
> > if (option & 0x200)
> > np->full_duplex = 1;
> > - np->default_port = option & 15;
> > - if (np->default_port)
> > - np->medialock = 1;
> > + if (option & 15)
> > + printk(KERN_INFO "%s: ignoring user supplied media type %d",
> > + dev->name, option & 15);
> > }
> > if (find_cnt < MAX_UNITS && full_duplex[find_cnt] > 0)
> > np->full_duplex = 1;
>
> I'm not sure this part is something we want in the mainstream kernel...
>

The winbond driver always ignored the user supplied media type, I only
added a warning.
medialock and default_port were write-only variables ;-)

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.039 / U:1.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site