Messages in this thread Patch in this message | | | From | kuznet@ms2 ... | Subject | Re: 2.4.4: Kernel crash, possibly tcp related | Date | Tue, 1 May 2001 22:10:03 +0400 (MSK DST) |
| |
Hello!
> If send_head doesn't point to skb then it is before it (and it cannot > advance under us of course because we hold the sock lock) and so in such > case we didn't clobbered the send_head at all in skb_entail, and so we > don't need to touch send_head in order to undo (we only need to unlink). > > See?
I see! Dave, please, take the second Andrea's patch (appended). It is really the cleanest one.
Alexey
--- 2.4.4aa3/net/ipv4/tcp.c.~1~ Tue May 1 10:44:57 2001 +++ 2.4.4aa3/net/ipv4/tcp.c Tue May 1 12:00:25 2001 @@ -1183,11 +1183,8 @@ do_fault: if (skb->len==0) { - if (tp->send_head == skb) { - tp->send_head = skb->next; - if (tp->send_head == (struct sk_buff*)&sk->write_queue) - tp->send_head = NULL; - } + if (tp->send_head == skb) + tp->send_head = NULL; __skb_unlink(skb, skb->list); tcp_free_skb(sk, skb); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |