Messages in this thread Patch in this message |  | | Date | Tue, 1 May 2001 14:09:28 +0200 | Subject | Re: 2.2.19 locks up on SMP | From | Trond Myklebust <> |
| |
>>>>> " " == Ion Badulescu <ionut@cs.columbia.edu> writes:
> On Tue, 1 May 2001, Ion Badulescu wrote: >> I'll do another test, 2.2.18 + the NFS/SunRPC changes, and see >> how it goes. Hopefully they'll apply easily...
> As I suspected, 2.2.18 + all the NFS/NFSd/SunRPC changes > present in 2.2.19pre10 locks up with wait_on_bh as soon as I > run ls -lR on a large NFS directory tree, while at the same > time pummeling the network and the local disks.
> NFS is not enough to trigger the bug, the extra disk/network > stress *is* necessary. The network stress actually seems to be > enough, I just triggered the bug again...
> 2.2.18 vanilla is fine.
> So I guess the next round is in Trond's court. :-)
Did you apply the following patch which I put out on the lists a couple of weeks ago?
Cheers, Trond
--- net/sunrpc/xprt.c.orig Sun Mar 25 18:37:42 2001 +++ net/sunrpc/xprt.c Wed Apr 18 11:10:21 2001 @@ -1145,9 +1145,11 @@ unsigned long oldflags; spin_lock_irqsave(&xprt_sock_lock, oldflags); xprt->snd_task = NULL; - if (!rpc_wake_up_next(&xprt->sending) && xprt->stream) + if (!rpc_wake_up_next(&xprt->sending) && xprt->stream) { + spin_unlock_irqrestore(&xprt_sock_lock, oldflags); xprt_add_tcp_timer(xprt, RPCXPRT_TIMEOUT); - spin_unlock_irqrestore(&xprt_sock_lock, oldflags); + } else + spin_unlock_irqrestore(&xprt_sock_lock, oldflags); } } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |