Messages in this thread |  | | From | Andrzej Krzysztofowicz <> | Subject | Re: iso9660 endianness cleanup patch | Date | Tue, 1 May 2001 16:40:58 +0200 (CEST) |
| |
Are you sure that the arguments of the following casting
> + return le16_to_cpu(*(u16 *)p);
> + return be16_to_cpu(*(u16 *)p);
> + return le32_to_cpu(*(u32 *)p);
> + return be32_to_cpu(*(u32 *)p);
are properly aligned ? I did not revise the code to check it, but AFAIK improperly aligned char* pointers cause problem with casting to pointers to 16/32-bit data on some architectures (I heard of sucj a problem with alpha).
Maybe there was a reason that the original code did operate on bytes here...
Andrzej
-- ======================================================================= Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl phone (48)(58) 347 14 61 Faculty of Applied Phys. & Math., Technical University of Gdansk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |