Messages in this thread | | | Date | Thu, 5 Apr 2001 17:37:31 +0200 | From | Jens Axboe <> | Subject | Re: /dev/loop0 over lvm... leading to d-state :-( |
| |
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > Irks, another one. lvm_make_request_fn also needs to call b_end_io > > if a map fails. > > This is wrong. > > In case of an io error we do already call buffer_IO_error() on 2.4 in > lvm_map().
Where? Calling buffer_IO_error would be ok, but there are no such calls in 2.4.3. I just stated elsewhere that submit_bh should probably be clearing the dirty bit, not ll_rw_block, in which case the b_end_io is fine. But buffer_IO_error is probably more clear. I trust you'll take care of that part then.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |