lkml.org 
[lkml]   [2001]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cleanup for fixing get_super() races

On Fri, 27 Apr 2001, Alexander Viro wrote:
>
> Each of these places is an oopsable race with umount. We can't fix them
> without touching a lot of drivers. However, we can make the future fix
> easier if we put the above into a helper function. Patch below does that.

I don't like the name "ream_inodes()".

Also, a driver shouldn't know about "inodes" and "buffers". It should just
do something like

invalidate_device(dev);

because the only thing the driver knows about is the _device_.

Then, invalidate_device() might do

sb = get_super(dev)
if (sb)
invalidate_inodes (sb);
invalidate_buffers(dev);

which makes some amount of sense. And which can later be extended to deal
with the page cache etc without the drivers ever knowing or caring.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.048 / U:2.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site