lkml.org 
[lkml]   [2001]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] proc_mknod() should check the mode parameter


    On Wed, 18 Apr 2001, Erik Mouw wrote:

    > Hi all,
    >
    > While documenting the procfs interface (more of that later), I came
    > across proc_mknod() which is supposed to be used to create devices in
    > the procfs. IMHO it should therefore check if the mode parameter
    > contains S_IFBLK or S_IFCHR.

    Why? All callers of proc_mknod() are in the kernel and they should
    know better. I could understand
    if (....)
    BUG();
    but silently doing nothing is really odd.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:0.022 / U:1.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site