Messages in this thread Patch in this message | | | Date | Tue, 06 Mar 2001 15:13:18 -0800 | From | David Brownell <> | Subject | Re: SLAB vs. pci_alloc_xxx in usb-uhci patch |
| |
> Anyways, is this the end of the discussion regarding my patch?
I think one of the maintainers for usb-uhci (Georg) said he'd want the general fix ...
> Manfred said plainly "usb-uhci is broken", Alan kinda > manuevered around my small problem, Dave Brownell looks > unconvinced. So?
There are two problems I see.
(1) CONFIG_SLAB_DEBUG breaks the documented requirement that the slab cache return adequately aligned data ... which the appended patch should probably handle nicely (something like it sure did :-) and with less danger than the large patch you posted.
(2) The USB host controller drivers all need something like a pci_consistent slab cache, which doesn't currently exist. I have something like that in the works, and David Miller noted one driver that I may steal from.
- Dave
--- slab.c-orig Tue Mar 6 15:01:26 2001 +++ slab.c Tue Mar 6 15:05:58 2001 @@ -676,12 +676,10 @@ } #if DEBUG + /* redzoning would break cache alignment requirements */ + if (flags & SLAB_HWCACHE_ALIGN) + flags &= ~SLAB_RED_ZONE; if (flags & SLAB_RED_ZONE) { - /* - * There is no point trying to honour cache alignment - * when redzoning. - */ - flags &= ~SLAB_HWCACHE_ALIGN; size += 2*BYTES_PER_WORD; /* words for redzone */ } #endif
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |