Messages in this thread | | | Date | Mon, 26 Mar 2001 11:02:13 +0400 | From | Oleg Drokin <> | Subject | Re: IP layer bug? |
| |
Hello!
On Mon, Mar 26, 2001 at 05:51:43PM +0530, Manoj Sontakke wrote: > > > ip_options_compile() when called with first argument NULL resets cb to 0. > > I have found that already. > > > underlying layer(link and phy) could be anything so where from the > > > ip_options should start will depend upon the underlying layer. > > But here's the problem! > > If I won't zero cb in my driver before netif_rx() call, > > IP layer thinks that all my packets have various ip options set > > (source routing most notable) > U can set cb to zero, but u also plan to use cb for storing ur data. If I use it for storing data, but when I do netif_rx() on skb, I cannot touch it anymore, so no data there is belong to me, and if I read that code in ip_input.c, it gets zeroed. BTW, I found that it's not ip_input.c that sends me 'source routing rejected' message, because no message is logged. It might be some other place. But anyway something is wrong in IP layer.
> that happens then u need to modify the way the macro IPCB > (probably in net/ip.h) is defined. Also make sure to increase the size > of cb to accomodate ur data. This will solve ur problem but making this My data perfectly fits in cb of current size.
> general (part of the standard kernel code) needs a lot of work in the ip > layer. The cb is also used by TCP. The same needs to be done in IP layer > but this will again largly depend on the layers below and hence the > complexity. But comment in skbuff.h claims that any owner of skb can use cb for its own needs, till it passes ownership to whoever else.
> The alternative to this is that u can add another buffer like cb in > sk_buff. What for?
Bye, Oleg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |