Messages in this thread | | | Subject | Re: Linux 2.4.2ac22 | From | (Kevin Buhr) | Date | 23 Mar 2001 13:43:45 -0600 |
| |
Alan Cox <alan@lxorguk.ukuu.org.uk> writes: > > > > o Fix ppp memory corruption (Kevin Buhr) > > > | Bizzarely enough a direct re-invention of a 1.2 ppp bug > > > > Could this explain my MPPP skb corruption I've reported since 2.3.x?
Unless you saw this corruption immediately after a hardware-initiated TTY hangup, my patch wouldn't have had anything to do with it.
> At most it explains some weird corruption cases with small kernel blocks. > I really doubt they are related
And, because I screwed up, the patch doesn't have any effect on PPP over async TTYs in 2.4.2, anyway. The compatibility code for pre-2.4.0 versions of "pppd", which was the real source of the problem, was removed in kernel 2.4.2, and the patch has no effect.
The compatibility code is still in the PPP-over-sync-TTY code, but once that's removed, we can back the patch out.
There are still horrible locking problems, but they represent a problem with the TTY line discipline switching code. It's possible for the line discipline to be "close"d asynchronously by the "eventd" kernel thread while other line discipline functions (even "open"!) are sleeping. Once this is fixed, the vanilla 2.4.2 "ppp_async.c" code (i.e., without my patch) should be lock-proof.
Kevin <buhr@stat.wisc.edu> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |