Messages in this thread | | | Date | Thu, 22 Mar 2001 12:20:48 -0500 (EST) | From | Alexander Viro <> | Subject | Re: lock_kernel() usage and sync_*() functions |
| |
On Thu, 22 Mar 2001, Ingo Oeser wrote:
> Could we remove the "magic" sync_flag from the exported interface?
Sure. But I seriously suspect that sync_dev() is wrong in 100% of cases. So "flag" is eventually going to become "do we want to sync it or not?" thing. However, I don't want to deal with that sort of analysis right now - callers are in drivers/* and we are in even branch. > Do sth. like renaming your invalidate_dev() to > _invalidate_dev() and adding 3 defines: > > #define invalidate_dev(dev) _invalidate_dev(dev,0) > #define invalidate_dev_sync(dev) _invalidate_dev(dev,1) > #define invalidate_dev_fsync(dev) _invalidate_dev(dev,2) > > This would make it quite clear, what will be done. > > AFAIR Linus dosn't like these magic numers either, right?
I also don't like them. I _don't_ believe that magic #defines are any better, though. And I would rather localize the get_super() to kernel proper preserving the current behaviour and left dealing with the sync vs. fsync to 2.5. It's easy to grep and if my gut feeling is correct your invalidate_dev_sync() is going to be a ballast.
Again, for 2.4 I would rather do a change that obviously doesn't change behaviour of drivers, doesn't add functions without need and is easy to review once drivers become a fair game again (== in 2.5). Comments? Cheers, Al
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |