lkml.org 
[lkml]   [2001]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] Does this correct a bug in ibmcam.c?
Date
From
> +			int chan;
>
> - if (copy_from_user(&v, arg, sizeof(v)))
> - return -EFAULT;
> - if ((v < 0) || (v >= 3)) /* 3 grades of lighting conditions */
> - return -EINVAL;
> - if (v != ibmcam->vchan.channel) {
> - ibmcam->vchan.channel = v;
> + chan = (int)arg;
> +
> + if ((chan < 0) || (chan >= 3)) /* 3 grades of lighting conditions */
> + return -EINVAL;
> +
> + if (chan != ibmcam->vchan.channel) {
> + ibmcam->vchan.channel = chan;
> usb_ibmcam_change_lighting_conditions(ibmcam);
> - }
> + }
> return 0;
> }

This change is wrong. I think you are calling the ioctl wrongly

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.042 / U:5.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site