Messages in this thread | | | Date | Thu, 01 Mar 2001 15:52:08 -0500 | From | Chris Mason <> | Subject | Re: [CFT][PATCH] Re: fat problem in 2.4.2 |
| |
On Thursday, March 01, 2001 12:05:50 PM -0800 Linus Torvalds <torvalds@transmeta.com> wrote:
> In article <Pine.GSO.4.21.0103011345110.11577-100000@weyl.math.psu.edu>, > Alexander Viro <viro@math.psu.edu> wrote: >> >> Alan, fix is really quite simple. Especially if you have vmtruncate() >> returning int (ac1 used to do it, I didn't check later ones). Actually >> just a generic_cont_expand() done on expanding path in vmtruncate() >> will be enough - it should be OK for all cases, including normal >> filesystems. <grabbing -ac7> >> >> OK, any brave soul to test that? All I can promise that it builds. > > This looks like it would create a dummy block even for non-broken > filesystems (ie truncating a file to be larger on ext2 would create a > block, no?). While that would work, it would also waste disk-space.
Another idea is to create the hole for new_file_size + [one block], and then truncate that block off the end of the file, leaving nothing but the hole. I'll never admit to suggesting it though.
-chris
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |