lkml.org 
[lkml]   [2001]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/media/radio/radio-maxiradio.c - 2.4.1-ac8
Francois Romieu wrote:
> --- linux-2.4.1-ac8.orig/drivers/media/radio/radio-maxiradio.c Fri Feb 9 15:55:03 2001
> +++ linux-2.4.1-ac8/drivers/media/radio/radio-maxiradio.c Fri Feb 9 15:56:55 2001
> @@ -376,9 +376,7 @@
>
> int __init maxiradio_radio_init(void)
> {
> - int count = pci_register_driver(&maxiradio_driver);
> -
> - if(count > 0) return 0; else return -ENODEV;
> + return pci_module_init(&maxiradio_driver);
> }
>
> void __exit maxiradio_radio_exit(void)

Patch looks ok. Further change: move pci_enable_device above the
request_region call. request_region calls pci_resource_start(), which
may not return a proper value if called before pci_enable_device.

Jeff



--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.058 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site